9aman commented on code in PR #14828:
URL: https://github.com/apache/pinot/pull/14828#discussion_r1925228679
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1889,4 +1889,19 @@ String moveSegmentFile(String rawTableName, String
segmentName, String segmentLo
URI createSegmentPath(String rawTableName, String segmentName) {
return URIUtils.getUri(_controllerConf.getDataDir(), rawTableName,
URIUtils.encode(segmentName));
}
+
+ public Set<String> getSegmentsYetToBeCommitted(String tableNameWithType,
Set<String> segmentsToCheck) {
+ Set<String> segmentsYetToBeCommitted = new HashSet<>();
+ for (String segmentName: segmentsToCheck) {
+ SegmentZKMetadata segmentZKMetadata =
+ _helixResourceManager.getSegmentZKMetadata(tableNameWithType,
segmentName);
+ if (segmentZKMetadata == null) {
+ continue;
+ }
+ if (!segmentZKMetadata.getStatus().isCompleted()) {
Review Comment:
isCompleted should return true only when the stratus is Uploaded or Done.
Raising a PR along with few minor improvement wrt pauseless,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
