Jackie-Jiang commented on code in PR #14910:
URL: https://github.com/apache/pinot/pull/14910#discussion_r1927786088
##########
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitionsUtils.java:
##########
@@ -59,13 +59,13 @@ public static String getInstancePartitionsName(String
tableName, String instance
/**
* Fetches the instance partitions from Helix property store if it exists,
or computes it for backward-compatibility.
*/
- public static InstancePartitions
fetchOrComputeInstancePartitions(HelixManager helixManager, TableConfig
tableConfig,
- InstancePartitionsType instancePartitionsType) {
+ public static InstancePartitions
fetchOrComputeInstancePartitionsForSegmentAssignment(HelixManager helixManager,
Review Comment:
Can you elaborate more on this renaming? Not sure if there are third party
code calling this method since it is a util
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
