klsince commented on code in PR #14894:
URL: https://github.com/apache/pinot/pull/14894#discussion_r1927831616
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -403,7 +407,7 @@ public void downloadAndLoadSegment(SegmentZKMetadata
zkMetadata, IndexLoadingCon
String segmentName = zkMetadata.getSegmentName();
_logger.info("Downloading and loading segment: {}", segmentName);
File indexDir = downloadSegment(zkMetadata);
- addSegment(ImmutableSegmentLoader.load(indexDir, indexLoadingConfig));
+ addSegment(ImmutableSegmentLoader.load(indexDir, indexLoadingConfig,
_segmentPreprocessThrottler));
Review Comment:
does it make sense to add a TODO that the current
`_segmentDownloadSemaphore` (the one to throttle segment download and segment
decompression) should be made dynamic as well to avoid restarting servers when
need to throttle them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
