Jackie-Jiang commented on code in PR #14918:
URL: https://github.com/apache/pinot/pull/14918#discussion_r1931086389
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/utils/ParserUtils.java:
##########
@@ -53,95 +54,87 @@ public static boolean canCompileWithMultiStageEngine(String
query, String databa
}
/**
- * Tries to fill an empty or not properly filled schema when no rows have
been returned.
+ * Tries to fill an empty or not properly filled {@link DataSchema} when no
row has been returned.
+ *
+ * Response data schema can be inaccurate or incomplete in several forms:
+ * 1. No result table at all (when all segments have been pruned on broker).
+ * 2. Data schema has all columns set to default type (STRING) (when all
segments pruned on server).
Review Comment:
We probably need a dev focus documentation to document the internal
behaviors. It is always a hard problem to keep the doc in sync with code
though. I'd prefer having it in javadoc for now for future developers to know
the history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
