ankitsultana commented on code in PR #14841: URL: https://github.com/apache/pinot/pull/14841#discussion_r1932730153
########## pinot-core/src/main/java/org/apache/pinot/core/operator/timeseries/TimeSeriesOperatorUtils.java: ########## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.timeseries; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.core.data.table.Record; +import org.apache.pinot.core.operator.blocks.results.AggregationResultsBlock; +import org.apache.pinot.core.operator.blocks.results.GroupByResultsBlock; +import org.apache.pinot.tsdb.spi.TimeBuckets; +import org.apache.pinot.tsdb.spi.series.BaseTimeSeriesBuilder; +import org.apache.pinot.tsdb.spi.series.TimeSeries; +import org.apache.pinot.tsdb.spi.series.TimeSeriesBlock; + + +public class TimeSeriesOperatorUtils { + private TimeSeriesOperatorUtils() { + } + + public static TimeSeriesBlock buildTimeSeriesBlock(TimeBuckets timeBuckets, + GroupByResultsBlock groupByResultsBlock) { + if (groupByResultsBlock.getNumRows() == 0) { + return new TimeSeriesBlock(timeBuckets, new HashMap<>()); + } + if (groupByResultsBlock.isNumGroupsLimitReached()) { Review Comment: Good catch. I am updating this in the next PR. Scope of next PR is: * Take in API parameter to control series limit. We will integrate that with V1 Engine via the numGroupsLimit config. * Don't throw error on group limit reached. note that throwing on series limit is same as the behavior before this PR. I didn't want to change it in this PR because I wanted to test it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
