[ 
https://issues.apache.org/jira/browse/PIRK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426628#comment-15426628
 ] 

ASF GitHub Bot commented on PIRK-55:
------------------------------------

Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/66#discussion_r75328858
  
    --- Diff: pom.xml ---
    @@ -464,7 +464,7 @@
                                        <version>3.0.1</version>
                                        <configuration>
                                                <excludes>
    -                                                   
<exclude>org/apache/pirk/benchmark/**</exclude>
    +                                                   
<exclude>org/apache/pirk/test/benchmark/**</exclude>
    --- End diff --
    
    Don't think this is needed, the test/ folder is never packaged into Maven 
artifacts. 


> Move all tests under src/test directory
> ---------------------------------------
>
>                 Key: PIRK-55
>                 URL: https://issues.apache.org/jira/browse/PIRK-55
>             Project: PIRK
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Tim Ellison
>            Assignee: Tim Ellison
>
> Pirk's tests are currently split across the src/test and src/main directories.
> This issue is to bring the tests together in a single place, and adopt 
> org.apache.pirk.test. as the package prefix for all the project's tests.
> The consistency will make it easier for people to find the tests to run them, 
> and exclude tests from implementation where required (packaging, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to