[
https://issues.apache.org/jira/browse/PIRK-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556158#comment-15556158
]
ASF GitHub Bot commented on PIRK-45:
------------------------------------
GitHub user wraydulany opened a pull request:
https://github.com/apache/incubator-pirk/pull/107
[WIP] PIRK-45 Remove dependency on Java serialization
This is a WIP (do not merge) for adding in JSON serialization. I can't get
this WIP to pass the elasticsearch spark streaming tests on my cluster.
I'm fairly sure that this is a configuration problem on my end (the errors
I get appear to be such), but I'm having little luck resolving them, and would
love it if some of the community could give it a test.
I've left in Java Serialization for now, but I've made JSON serialization
the default.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wraydulany/incubator-pirk PIRK-45
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit c2c6af2465e21cd706c8cfd0dc4f95f7746d86f0
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-09-28T15:13:12Z
Initial start on moving away from Java object serialization.
commit 66235a9c6ac07e3cec6a94c0874b40bf6624192e
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-09-29T17:02:17Z
Initial work.
commit 03b4964c2b25538aaecfdcd56a408bcba8154688
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-01T17:20:09Z
Merge branch 'master' of https://github.com/wraydulany/incubator-pirk into
PIRK-45
commit de01c5ad1e670200cefa6c7dfc2b678cb245eaf6
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-01T17:21:27Z
Merge branch 'master' of https://github.com/wraydulany/incubator-pirk into
PIRK-45
commit 7b221de870f7efc8b41ec52fd5d05af06360c405
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-04T18:24:18Z
Added deserializer for query; I think I should delete the serializer for
QueryInfo.
commit fdeb7d77117691f7dda63a2a180d805861216893
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-04T19:21:22Z
Query serialization seems to be working now; at least it doesn't fail to
get recalled.
commit b31afcfe7f01ebda6a19e27b5e651f8dc8763f16
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-04T19:42:20Z
Response deserializer compiles.
commit 42e2bb6082a601e5e503e76170499baff37fc478
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-05T12:31:51Z
Custom deserializers complete, as are class amendments to make them work.
commit 603fcaa777f754dbf60836a8a81b7239b39ae494
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-05T14:29:21Z
Merge remote-tracking branch 'upstream/master' into PIRK-45
commit fbebc4adafefa640e5b0339d2423abdabed9b0b3
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-05T15:59:55Z
Needed to add a new constructor for QueryInfo so as to not depend on the
existence of a populated QuerySchemaRegistry.
commit b9caf260f14405705864ba200d993057a7040416
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-06T12:16:34Z
Move to gson breaks hdfs?
commit dc9fcfd848c89bf59310c0c12284b5bbb72caec4
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-06T12:49:45Z
Working with Gson on two tests; time for distributed tests.
commit 99cddd1981f76569d63add70a6351ba744ca13c9
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date: 2016-10-07T20:19:48Z
Merge remote-tracking branch 'upstream/master' into PIRK-45
----
> Remove dependency on Java serialization
> ---------------------------------------
>
> Key: PIRK-45
> URL: https://issues.apache.org/jira/browse/PIRK-45
> Project: PIRK
> Issue Type: Improvement
> Reporter: Tim Ellison
> Assignee: Walter Ray-Dulany
>
> Pirk should not depend upon Java serialization as a persistent object format.
> Maintaining support for a variety of versions of Java serialized form can be
> difficult, this includes both the querier and responder sides of a PIR.
> Alternative formats such as XML and JSON are more forgiving/extensible.
> Furthermore, and despite Pirk's trust between querier and responder, there
> are potential implications for loading the binary representation of Java's
> serialized instances as a vector for security vulnerabilities.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
