(plc4x) branch develop updated: chore(QA): fix some warnings during build

[sruehl]

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new 84d77e775b chore(QA): fix some warnings during build
84d77e775b is described below

commit 84d77e775bc7243cd63063aff156e1a4fdbdc483
Author: Sebastian Rühl <sru...@apache.org>
AuthorDate: Mon Oct 30 11:45:15 2023 +0100

    chore(QA): fix some warnings during build
---
 .../ads/src/main/java/org/apache/plc4x/protocol/ads/ADSProtocol.java | 4 ----
 .../apache/plc4x/protocol/knxnetip/KnxSpecificationStoreUpdater.java | 5 +++--
 .../org/apache/plc4x/protocol/plc4xapi/v0/Plc4xProtocolTest.java     | 1 -
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git 
a/protocols/ads/src/main/java/org/apache/plc4x/protocol/ads/ADSProtocol.java 
b/protocols/ads/src/main/java/org/apache/plc4x/protocol/ads/ADSProtocol.java
index b5e175f75f..7a63e7efd6 100644
--- a/protocols/ads/src/main/java/org/apache/plc4x/protocol/ads/ADSProtocol.java
+++ b/protocols/ads/src/main/java/org/apache/plc4x/protocol/ads/ADSProtocol.java
@@ -18,7 +18,6 @@
  */
 package org.apache.plc4x.protocol.ads;
 
-import 
org.apache.plc4x.plugins.codegenerator.language.mspec.model.definitions.DefaultComplexTypeDefinition;
 import 
org.apache.plc4x.plugins.codegenerator.language.mspec.parser.MessageFormatParser;
 import 
org.apache.plc4x.plugins.codegenerator.language.mspec.protocol.ProtocolHelpers;
 import 
org.apache.plc4x.plugins.codegenerator.language.mspec.protocol.ValidatableTypeContext;
@@ -26,9 +25,6 @@ import 
org.apache.plc4x.plugins.codegenerator.protocol.Protocol;
 import org.apache.plc4x.plugins.codegenerator.protocol.TypeContext;
 import 
org.apache.plc4x.plugins.codegenerator.types.exceptions.GenerationException;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-
 public class ADSProtocol implements Protocol, ProtocolHelpers {
 
     @Override
diff --git 
a/protocols/knxnetip/src/test/java/org/apache/plc4x/protocol/knxnetip/KnxSpecificationStoreUpdater.java
 
b/protocols/knxnetip/src/test/java/org/apache/plc4x/protocol/knxnetip/KnxSpecificationStoreUpdater.java
index 4ef6229343..5dbf3aee8e 100644
--- 
a/protocols/knxnetip/src/test/java/org/apache/plc4x/protocol/knxnetip/KnxSpecificationStoreUpdater.java
+++ 
b/protocols/knxnetip/src/test/java/org/apache/plc4x/protocol/knxnetip/KnxSpecificationStoreUpdater.java
@@ -47,6 +47,7 @@ public class KnxSpecificationStoreUpdater {
 
     /**
      * Description of the KNX Foundation Webservice: 
http://onlinecatalog.knx.org/Download/help
+     *
      * @param args
      */
     public static void main(String[] args) {
@@ -136,7 +137,7 @@ public class KnxSpecificationStoreUpdater {
                     int applicationId = applicationIdentifier.getInt(2) << 8 | 
applicationIdentifier.getInt(3);
                     int applicationVersion = applicationIdentifier.getInt(4) & 
0xFF;
 
-                    if(applicationId == 0 && applicationVersion == 0) {
+                    if (applicationId == 0 && applicationVersion == 0) {
                         System.out.println("SKIPPED");
                         continue;
                     }
@@ -148,7 +149,7 @@ public class KnxSpecificationStoreUpdater {
                     // Check If we've already got that file (There are no 
updates, just new versions)
                     File[] files = manufacturerDirectory.listFiles((dir, name) 
-> name.startsWith(productCode));
                     // If we've already got the file, skip loading it
-                    if(files.length > 0) {
+                    if (files.length > 0) {
                         System.out.println("SKIPPED");
                         continue;
                     }
diff --git 
a/protocols/plc4x-api/src/test/java/org/apache/plc4x/protocol/plc4xapi/v0/Plc4xProtocolTest.java
 
b/protocols/plc4x-api/src/test/java/org/apache/plc4x/protocol/plc4xapi/v0/Plc4xProtocolTest.java
index 19e3053210..9f8c38d080 100644
--- 
a/protocols/plc4x-api/src/test/java/org/apache/plc4x/protocol/plc4xapi/v0/Plc4xProtocolTest.java
+++ 
b/protocols/plc4x-api/src/test/java/org/apache/plc4x/protocol/plc4xapi/v0/Plc4xProtocolTest.java
@@ -19,7 +19,6 @@
 package org.apache.plc4x.protocol.plc4xapi.v0;
 
 import org.apache.plc4x.plugins.codegenerator.protocol.TypeContext;
-import org.apache.plc4x.protocol.plc4xapi.v0.Plc4xApi;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertNotNull;