chrisdutz commented on code in PR #2241:
URL: https://github.com/apache/plc4x/pull/2241#discussion_r2318382862
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/Plc4xNettyWrapper.java:
##########
@@ -136,10 +136,19 @@ public ExpectRequestContext<T> expectRequest(Class<T>
clazz, Duration timeout) {
@Override
public void close(ChannelHandlerContext ctx, ChannelPromise promise)
throws Exception {
+ logger.info("close.. context: {}", ctx.name());
super.close(ctx, promise);
timeoutManager.stop();
}
+ @Override
+ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
+ logger.info("channelInactive.. context: {}", ctx.name());
Review Comment:
Please set this to "debug" or "trace"
##########
plc4j/spi/src/test/java/org/apache/plc4x/java/spi/connection/DefaultNettyPlcConnectionTest.java:
##########
@@ -210,6 +213,13 @@ private void awaitIn(GateKeeper signal) {
throw new RuntimeException(e);
}
}
- }
+ @Override
+ public void channelInactive(ConversationContext<Message> context) {
+ logger.info("On ChannelInactive");
Review Comment:
Please set this to "debug" or "trace"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
