Author: onealj
Date: Thu Jan 19 09:01:39 2017
New Revision: 1779437

URL: http://svn.apache.org/viewvc?rev=1779437&view=rev
Log:
bug 60601: unset hyperlinks after removing them individually from the DOM

Modified:
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java?rev=1779437&r1=1779436&r2=1779437&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java 
(original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java Thu 
Jan 19 09:01:39 2017
@@ -3485,15 +3485,16 @@ public class XSSFSheet extends POIXMLDoc
             worksheet.getHyperlinks().setHyperlinkArray(ctHls);
         }
         else {
-            // For some reason, we have to remove the hyperlinks one by one 
from the CTHyperlinks array
-            // rather than unsetting or resetting the hyperlink array.
-            //worksheet.getHyperlinks().setHyperlinkArray(new CTHyperlink[0]);
-            //worksheet.unsetHyperlinks();
             if (worksheet.getHyperlinks() != null) {
                 final int count = 
worksheet.getHyperlinks().sizeOfHyperlinkArray();
                 for (int i=count-1; i>=0; i--) {
                     worksheet.getHyperlinks().removeHyperlink(i);
                 }
+                // For some reason, we have to remove the hyperlinks one by 
one from the CTHyperlinks array
+                // before unsetting the hyperlink array.
+                // Resetting the hyperlink array seems to break some XML nodes.
+                //worksheet.getHyperlinks().setHyperlinkArray(new 
CTHyperlink[0]);
+                worksheet.unsetHyperlinks();
             } else {
                 // nothing to do
             }



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to