Author: onealj
Date: Wed Feb  1 00:59:20 2017
New Revision: 1781191

URL: http://svn.apache.org/viewvc?rev=1781191&view=rev
Log:
release-prep1 should abort if release tag already exists. It's likely that the 
version was entered incorrectly or copy-pasted from a template.

Modified:
    poi/trunk/build.xml

Modified: poi/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/poi/trunk/build.xml?rev=1781191&r1=1781190&r2=1781191&view=diff
==============================================================================
--- poi/trunk/build.xml (original)
+++ poi/trunk/build.xml Wed Feb  1 00:59:20 2017
@@ -2441,8 +2441,26 @@ under the License.
         />
     </target>
 
+    <target name="release-prep0" depends="-init-svn" description="check to 
make sure the release tag doesn't exist yet">
+        <!-- verify that svn username/password are valid ... -->
+        <fail message="Unable to connect to SVN repo. Verify apache-id 
username and password.">
+            <condition>
+                <!-- FIXME: svnExists doesn't work with https here. -->
+                <not><svnExists refid="svn.settings" 
target="http://svn.apache.org/repos/asf/poi/"/></not>
+            </condition>
+        </fail>
+
+        <!-- verify that the release tag that we're about to create in 
release-prep1 does not already exist (no overwriting tags!) -->
+        <fail message="Cannot create release tag. 
https://svn.apache.org/repos/asf/poi/tags/${RELEASE_TAG} already exists. Verify 
the requested release version.">
+            <condition>
+                <!-- FIXME: svnExists doesn't work with https here. -->
+                <svnExists refid="svn.settings" 
target="http://svn.apache.org/repos/asf/poi/tags/${RELEASE_TAG}/"/>
+            </condition>
+        </fail>
+    </target>
+
     <!-- experimental release preparation ... tbd. ... -->
-    <target name="release-prep1" depends="-init-svn" description="update the 
documentation and create the svn tag - needs Java7+">
+    <target name="release-prep1" depends="-init-svn,release-prep0" 
description="update the documentation and create the svn tag - needs Java7+">
         <local name="tstamp_rel"/>
         <local name="tstamp_next"/>
         <local name="rel_next"/>



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to