Author: fanningpj
Date: Thu Aug 25 18:28:06 2022
New Revision: 1903684
URL: http://svn.apache.org/viewvc?rev=1903684&view=rev
Log:
sonar issues
Modified:
xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDate.java
xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDateBuilder.java
xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/config/BindingConfigImpl.java
Modified: xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDate.java
URL:
http://svn.apache.org/viewvc/xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDate.java?rev=1903684&r1=1903683&r2=1903684&view=diff
==============================================================================
--- xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDate.java (original)
+++ xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDate.java Thu Aug 25
18:28:06 2022
@@ -382,7 +382,7 @@ public final class GDate implements GDat
* The current offset of the default timezone is used as the timezone.
* <p>
* For example, if eastern daylight time is in effect at the given
- * date, the timezone on the east coast of the united states
+ * date, the timezone on the east coast of the United States
* translates to GMT-05:00 (EST) + 1:00 (DT offset) == GMT-04:00.
*/
public GDate(Date date) {
Modified: xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDateBuilder.java
URL:
http://svn.apache.org/viewvc/xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDateBuilder.java?rev=1903684&r1=1903683&r2=1903684&view=diff
==============================================================================
--- xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDateBuilder.java
(original)
+++ xmlbeans/trunk/src/main/java/org/apache/xmlbeans/GDateBuilder.java Thu Aug
25 18:28:06 2022
@@ -25,7 +25,7 @@ import java.util.TimeZone;
/**
* Used to build {@link GDate GDates}.
* <p>
- * Like GDate, a GDateBuilder represents an Gregorian Date, Time,
+ * Like GDate, a GDateBuilder represents a Gregorian Date, Time,
* and Timezone, or subset of information (Year, Month, Day,
* Time, Timezone, or some combination). Wherever it provides
* guidance, the XML Schema 1.0 specification (plus published
@@ -234,7 +234,7 @@ public final class GDateBuilder implemen
* The current offset of the default timezone is used as the timezone.
* <p>
* For example, if eastern daylight time is in effect at the given
- * date, the timezone on the east coast of the united states
+ * date, the timezone on the east coast of the United States
* translates to GMT-05:00 (EST) + 1:00 (DT offset) == GMT-04:00.
*
* @param date the date object to copy
@@ -609,7 +609,7 @@ public final class GDateBuilder implemen
if (date.hasTimeZone() &&
(!((date.getTimeZoneSign() == 0 && date.getTimeZoneHour() == 0 &&
date.getTimeZoneMinute() == 0) ||
- ((date.getTimeZoneSign() == -1 || date.getTimeZoneSign() == +1)
&&
+ ((date.getTimeZoneSign() == -1 || date.getTimeZoneSign() == 1)
&&
// NB: allow +00:00 and -00:00
// (date.getTimeZoneHour() == 0 && date.getTimeZoneMinute() >
0 || date.getTimeZoneHour() > 0 && date.getTimeZoneMinute() >= 0) &&
(date.getTimeZoneHour() >= 0 && date.getTimeZoneMinute() >= 0)
&&
Modified:
xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/config/BindingConfigImpl.java
URL:
http://svn.apache.org/viewvc/xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/config/BindingConfigImpl.java?rev=1903684&r1=1903683&r2=1903684&view=diff
==============================================================================
---
xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/config/BindingConfigImpl.java
(original)
+++
xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/config/BindingConfigImpl.java
Thu Aug 25 18:28:06 2022
@@ -74,21 +74,23 @@ public class BindingConfigImpl extends B
List<? extends XmlAnySimpleType> applyto =
qnameconfig.xgetTarget().xgetListValue();
QName name = qnameconfig.getName();
String javaname = qnameconfig.getJavaname();
- for (Object o : applyto) {
- Qnametargetenum a = (Qnametargetenum) o;
- switch (a.getEnumValue().intValue()) {
- case Qnametargetenum.INT_TYPE:
- _qnameTypeMap.put(name, javaname);
- break;
- case Qnametargetenum.INT_DOCUMENT_TYPE:
- _qnameDocTypeMap.put(name, javaname);
- break;
- case Qnametargetenum.INT_ACCESSOR_ELEMENT:
- _qnameElemMap.put(name, javaname);
- break;
- case Qnametargetenum.INT_ACCESSOR_ATTRIBUTE:
- _qnameAttMap.put(name, javaname);
- break;
+ for (XmlAnySimpleType xmlAnySimpleType : applyto) {
+ if (xmlAnySimpleType instanceof Qnametargetenum) {
+ Qnametargetenum a = (Qnametargetenum) xmlAnySimpleType;
+ switch (a.getEnumValue().intValue()) {
+ case Qnametargetenum.INT_TYPE:
+ _qnameTypeMap.put(name, javaname);
+ break;
+ case Qnametargetenum.INT_DOCUMENT_TYPE:
+ _qnameDocTypeMap.put(name, javaname);
+ break;
+ case Qnametargetenum.INT_ACCESSOR_ELEMENT:
+ _qnameElemMap.put(name, javaname);
+ break;
+ case Qnametargetenum.INT_ACCESSOR_ATTRIBUTE:
+ _qnameAttMap.put(name, javaname);
+ break;
+ }
}
}
}
@@ -105,7 +107,6 @@ public class BindingConfigImpl extends B
}
secondPhaseValidation();
- //todo normalize();
}
void addInterfaceExtension(InterfaceExtensionImpl ext) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
