Author: fanningpj
Date: Thu Aug 25 19:09:14 2022
New Revision: 1903687
URL: http://svn.apache.org/viewvc?rev=1903687&view=rev
Log:
sonar issues
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java?rev=1903687&r1=1903686&r2=1903687&view=diff
==============================================================================
---
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java
(original)
+++
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java
Thu Aug 25 19:09:14 2022
@@ -282,7 +282,7 @@ public abstract class OPCPackage impleme
throw new IllegalArgumentException("file must not be a directory");
}
- OPCPackage pack = new ZipPackage(file, access);
+ OPCPackage pack = new ZipPackage(file, access); //NOSONAR
try {
if (pack.partList == null && access != PackageAccess.WRITE) {
pack.getParts();
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java?rev=1903687&r1=1903686&r2=1903687&view=diff
==============================================================================
---
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java
(original)
+++
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java
Thu Aug 25 19:09:14 2022
@@ -234,7 +234,11 @@ import org.apache.poi.util.Internal;
public boolean untrackColumns(Collection<Integer> columns)
{
untrackedColumns.addAll(columns);
- return maxColumnWidths.keySet().removeAll(columns);
+ boolean result = false;
+ for (Integer col : columns) {
+ result = maxColumnWidths.remove(col) != null || result;
+ }
+ return result;
}
/**
@@ -248,7 +252,7 @@ import org.apache.poi.util.Internal;
*/
public boolean untrackColumn(int column) {
untrackedColumns.add(column);
- return maxColumnWidths.keySet().remove(column);
+ return maxColumnWidths.remove(column) != null;
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
