svn commit: r1919343 - in /poi/trunk: poi-ooxml/src/main/java/org/apache/poi/openxml4j/util/ZipArchiveFakeEntry.java poi-ooxml/src/main/java/org/apache/poi/xdgf/usermodel/XmlVisioDocument.java poi/src/main/java/org/apache/poi/ddf/EscherRecord.java

[centic]

Author: centic
Date: Thu Jul 18 07:10:35 2024
New Revision: 1919343

URL: http://svn.apache.org/viewvc?rev=1919343&view=rev
Log:
Apply some IDE suggestions, improve JavaDoc and simplify reporting log messages

Modified:
    
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/util/ZipArchiveFakeEntry.java
    
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xdgf/usermodel/XmlVisioDocument.java
    poi/trunk/poi/src/main/java/org/apache/poi/ddf/EscherRecord.java

Modified: 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/util/ZipArchiveFakeEntry.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/util/ZipArchiveFakeEntry.java?rev=1919343&r1=1919342&r2=1919343&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/util/ZipArchiveFakeEntry.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/util/ZipArchiveFakeEntry.java
 Thu Jul 18 07:10:35 2024
@@ -69,8 +69,8 @@ import org.apache.poi.util.TempFile;
                 }
             } else {
                 tempFile = TempFile.createTempFile("poi-zip-entry", ".tmp");
-                LOG.atInfo().log("created for temp file {} for zip entry {} of 
size {} bytes",
-                        () -> tempFile.getAbsolutePath(), entry::getName, () 
-> entrySize);
+                LOG.atInfo().log("Creating temp file {} for zip entry {} of 
size {} bytes",
+                        tempFile.getAbsolutePath(), entry.getName(), 
entrySize);
                 IOUtils.copy(inp, tempFile);
             }
         } else {

Modified: 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xdgf/usermodel/XmlVisioDocument.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xdgf/usermodel/XmlVisioDocument.java?rev=1919343&r1=1919342&r2=1919343&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xdgf/usermodel/XmlVisioDocument.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xdgf/usermodel/XmlVisioDocument.java
 Thu Jul 18 07:10:35 2024
@@ -59,6 +59,11 @@ public class XmlVisioDocument extends PO
     protected XDGFMasters _masters;
     protected XDGFDocument _document;
 
+    /**
+     * Construct a VisioDocument from the given OPCPackage
+     * @param pkg The xml-base input for the Visio document
+     * @throws IOException If parsing the document fails
+     */
     public XmlVisioDocument(OPCPackage pkg) throws IOException {
         super(pkg, PackageRelationshipTypes.VISIO_CORE_DOCUMENT);
 
@@ -78,7 +83,7 @@ public class XmlVisioDocument extends PO
 
     /**
      * @param stream InputStream - closed when it is read
-     * @throws IOException
+     * @throws IOException If parsing the document fails
      */
     public XmlVisioDocument(InputStream stream) throws IOException {
         this(stream, true);
@@ -87,7 +92,7 @@ public class XmlVisioDocument extends PO
     /**
      * @param stream InputStream
      * @param closeStream Whether to close the InputStream
-     * @throws IOException
+     * @throws IOException If parsing the document fails
      * @since POI 5.2.5
      */
     public XmlVisioDocument(InputStream stream, boolean closeStream) throws 
IOException {

Modified: poi/trunk/poi/src/main/java/org/apache/poi/ddf/EscherRecord.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ddf/EscherRecord.java?rev=1919343&r1=1919342&r2=1919343&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ddf/EscherRecord.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ddf/EscherRecord.java Thu Jul 18 
07:10:35 2024
@@ -373,14 +373,14 @@ public abstract class EscherRecord imple
     public abstract EscherRecord copy();
 
     /**
-     * @param length the max record length allowed for EscherArrayProperty
+     * @param length the max number of children allowed for EscherRecords 
which support nesting
      */
     public static void setMaxNumberOfChildren(int length) {
         MAX_NUMBER_OF_CHILDREN = length;
     }
 
     /**
-     * @return the max record length allowed for EscherArrayProperty
+     * @return the max number of children allowed for EscherRecords which 
support nesting
      */
     public static int getMaxNumberOfChildren() {
         return MAX_NUMBER_OF_CHILDREN;



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org