Author: fanningpj
Date: Tue May 27 20:15:50 2025
New Revision: 1925874

URL: http://svn.apache.org/viewvc?rev=1925874&view=rev
Log:
[bug-69669] refactor

Modified:
    
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java

Modified: 
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java?rev=1925874&r1=1925873&r2=1925874&view=diff
==============================================================================
--- 
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java
 (original)
+++ 
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java
 Tue May 27 20:15:50 2025
@@ -587,6 +587,8 @@ public abstract class HSLFSimpleShape ex
 
     @Override
     public void setPlaceholder(Placeholder placeholder) {
+        // reset the placeholder details so that the next call to 
getPlaceholderDetails() will reinitialize it
+        _placeholderDetails = null;
         updateSPRecord(this, placeholder);
 
         if (placeholder == null) {
@@ -640,11 +642,6 @@ public abstract class HSLFSimpleShape ex
                 }
                 break;
         }
-        // reverted this call because of 
https://bz.apache.org/bugzilla/show_bug.cgi?id=69669
-        //getPlaceholderDetails().setPlaceholder(placeholder);
-
-        // reset the placeholder details so that the next call to 
getPlaceholderDetails() will reinitialize it
-        _placeholderDetails = null;
     }
 
     @Override



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to