This is an automated email from the ASF dual-hosted git repository.

fanningpj pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/poi.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1eee67fb8b sxssf workbook dispose no longer needed
1eee67fb8b is described below

commit 1eee67fb8b3ef6c881f8444cfbea5ecc203be741
Author: PJ Fanning <[email protected]>
AuthorDate: Fri Jul 11 19:50:51 2025 +0100

    sxssf workbook dispose no longer needed
---
 .../poi/examples/xssf/streaming/DeferredGeneration.java       | 11 ++++++-----
 .../org/apache/poi/examples/xssf/streaming/Outlining.java     |  7 ++++---
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git 
a/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java
 
b/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java
index 1b98bb26ab..de66e11554 100644
--- 
a/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java
+++ 
b/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java
@@ -53,12 +53,13 @@ public class DeferredGeneration {
 
             try (FileOutputStream fileOut = new 
FileOutputStream("DeferredGeneration.xlsx")) {
                 wb.write(fileOut);
-                //writeAvoidingTempFiles was added as an experimental change 
in POI 5.1.0
-                //wb.writeAvoidingTempFiles(fileOut);
-            } finally {
-                //the dispose call is necessary to ensure temp files are 
removed
-                wb.dispose();
+                // writeAvoidingTempFiles was added as an experimental change 
in POI 5.1.0
+                // wb.writeAvoidingTempFiles(fileOut);
             }
+            // finally {
+              // the dispose call is no longer necessary to ensure temp files 
are removed
+              // wb.dispose();
+            // }
             System.out.println("wrote DeferredGeneration.xlsx");
         }
     }
diff --git 
a/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java
 
b/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java
index 31b15dcb16..9258790da3 100644
--- 
a/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java
+++ 
b/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java
@@ -46,10 +46,11 @@ public class Outlining {
 
             try (FileOutputStream fileOut = new 
FileOutputStream("outlining_collapsed.xlsx")) {
                 wb2.write(fileOut);
-            } finally {
-                //the dispose call is necessary to ensure temp files are 
removed
-                wb2.dispose();
             }
+            // finally {
+              // the dispose call is no longer necessary to ensure temp files 
are removed
+              // wb2.dispose();
+            // }
         }
     }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to