This is an automated email from the ASF dual-hosted git repository.
fanningpj pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/poi.git
The following commit(s) were added to refs/heads/trunk by this push:
new f1e6b9d11c remove deprecated method getSeries (#864)
f1e6b9d11c is described below
commit f1e6b9d11c13174a34507a01650dbd00c9d79cba
Author: PJ Fanning <[email protected]>
AuthorDate: Fri Jul 25 13:08:29 2025 +0100
remove deprecated method getSeries (#864)
* remove deprecated method getSeries
* Update TestXDDFChartRemoveSeries.java
---
.../poi/xddf/usermodel/chart/XDDFChartData.java | 22 ----------------------
.../usermodel/chart/TestXDDFChartRemoveSeries.java | 16 +---------------
2 files changed, 1 insertion(+), 37 deletions(-)
diff --git
a/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
b/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
index 1dc47d47a4..983ef4f138 100644
---
a/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
+++
b/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
@@ -28,7 +28,6 @@ import org.apache.poi.logging.PoiLogManager;
import org.apache.poi.ss.util.CellReference;
import org.apache.poi.util.Beta;
import org.apache.poi.util.Internal;
-import org.apache.poi.util.Removal;
import org.apache.poi.xddf.usermodel.XDDFFillProperties;
import org.apache.poi.xddf.usermodel.XDDFLineProperties;
import org.apache.poi.xddf.usermodel.XDDFShapeProperties;
@@ -85,27 +84,6 @@ public abstract class XDDFChartData {
return valueAxes;
}
- /**
- * Calls to {@code getSeries().add(series)} or to {@code
getSeries().remove(series)}
- * may corrupt the workbook.
- *
- * <p>
- * Instead, use the following methods:
- * <ul>
- * <li>{@link #getSeriesCount()}</li>
- * <li>{@link #getSeries(int)}</li>
- * <li>{@link #addSeries(XDDFDataSource,XDDFNumericalDataSource)}</li>
- * <li>{@link #removeSeries(int)}</li>
- * </ul>
- *
- * @deprecated since POI 4.1.1
- */
- @Deprecated
- @Removal(version = "5.3")
- public List<Series> getSeries() {
- return Collections.unmodifiableList(series);
- }
-
public final int getSeriesCount() {
return series.size();
}
diff --git
a/poi-ooxml/src/test/java/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java
b/poi-ooxml/src/test/java/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java
index 8bea979e33..5ebd7d13b5 100644
---
a/poi-ooxml/src/test/java/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java
+++
b/poi-ooxml/src/test/java/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java
@@ -112,21 +112,7 @@ class TestXDDFChartRemoveSeries {
}
workbook.close();
}
-
- /**
- * Attempt to remove the first series by calling
chartData.getSeries().remove(0).
- * <p>
- * This used to corrupt the workbook but the returned <code>List</code> is
unmodifiable.
- */
- @Test
- void testRemoveSeries0() {
- procName = "testRemoveSeries0";
- fileName = procName + ".xlsx";
-
- assertThrows(UnsupportedOperationException.class, () ->
chartData.getSeries().remove(0));
- assertEquals(2, chartData.getSeriesCount());
- }
-
+
/**
* Remove the first series by calling chartData.removeSeries(0).
* <p>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
