This is an automated email from the ASF dual-hosted git repository.

fanningpj pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/poi.git


The following commit(s) were added to refs/heads/trunk by this push:
     new bdb467e84e Update TestXSSFWorkbook.java
bdb467e84e is described below

commit bdb467e84e7da11a7f5f76aa4248b6bb2aeaba1a
Author: PJ Fanning <[email protected]>
AuthorDate: Thu Aug 14 12:44:21 2025 +0100

    Update TestXSSFWorkbook.java
---
 .../poi/xssf/usermodel/TestXSSFWorkbook.java       | 33 +++++++++++-----------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git 
a/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java 
b/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
index 10826e97d2..ee2ae86aac 100644
--- 
a/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
+++ 
b/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
@@ -1315,23 +1315,24 @@ public final class TestXSSFWorkbook extends 
BaseTestXWorkbook {
     void testNewWorkbookWithTempFilePackagePartsClose() throws Exception {
         try (UnsynchronizedByteArrayOutputStream bos = 
UnsynchronizedByteArrayOutputStream.builder().get()) {
             ZipPackage.setUseTempFilePackageParts(true);
-            try (XSSFWorkbook workbook = new XSSFWorkbook()) {
-                XSSFSheet sheet = workbook.createSheet("sheet1");
-                XSSFRow row = sheet.createRow(0);
-                XSSFCell cell0 = row.createCell(0);
-                cell0.setCellValue("");
-                XSSFCell cell1 = row.createCell(1);
-                cell1.setCellErrorValue(FormulaError.DIV0);
-                XSSFCell cell2 = row.createCell(2);
-                cell2.setCellErrorValue(FormulaError.FUNCTION_NOT_IMPLEMENTED);
-                workbook.write(bos);
-                // workaround for https://github.com/apache/poi/issues/879
-                for (PackagePart part : workbook.getPackage().getParts()) {
-                    part.close();
-                }
-            } finally {
-                ZipPackage.setUseTempFilePackageParts(false);
+            XSSFWorkbook workbook = new XSSFWorkbook();
+            XSSFSheet sheet = workbook.createSheet("sheet1");
+            XSSFRow row = sheet.createRow(0);
+            XSSFCell cell0 = row.createCell(0);
+            cell0.setCellValue("");
+            XSSFCell cell1 = row.createCell(1);
+            cell1.setCellErrorValue(FormulaError.DIV0);
+            XSSFCell cell2 = row.createCell(2);
+            cell2.setCellErrorValue(FormulaError.FUNCTION_NOT_IMPLEMENTED);
+            workbook.write(bos);
+            List<PackagePart> packageParts = workbook.getPackage().getParts();
+            workbook.close();
+            // workaround for https://github.com/apache/poi/issues/879 (needs 
to happen after workbook close)
+            for (PackagePart part : packageParts) {
+                part.close();
             }
+        } finally {
+            ZipPackage.setUseTempFilePackageParts(false);
         }
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to