This is an automated email from the ASF dual-hosted git repository.

pjfanning pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/poi.git


The following commit(s) were added to refs/heads/trunk by this push:
     new a1e954f61c Reject prohibited NUL and ETX characters in sheet names 
(#1433)
a1e954f61c is described below

commit a1e954f61cb18b30b00fff2d190556c640fd9f22
Author: Aryan R. Ganjoo <[email protected]>
AuthorDate: Sun Oct 18 02:27:34 2026 +0530

    Reject prohibited NUL and ETX characters in sheet names (#1433)
    
    Reject prohibited control characters in sheet names
---
 poi/src/main/java/org/apache/poi/ss/util/WorkbookUtil.java     | 2 ++
 poi/src/test/java/org/apache/poi/ss/util/TestWorkbookUtil.java | 9 +++++++++
 2 files changed, 11 insertions(+)

diff --git a/poi/src/main/java/org/apache/poi/ss/util/WorkbookUtil.java 
b/poi/src/main/java/org/apache/poi/ss/util/WorkbookUtil.java
index eb7a67f08a..3b8bb2c97e 100644
--- a/poi/src/main/java/org/apache/poi/ss/util/WorkbookUtil.java
+++ b/poi/src/main/java/org/apache/poi/ss/util/WorkbookUtil.java
@@ -135,6 +135,8 @@ public class WorkbookUtil {
         for (int i=0; i<len; i++) {
             char ch = sheetName.charAt(i);
             switch (ch) {
+                case '\u0000':
+                case '\u0003':
                 case '/':
                 case '\\':
                 case '?':
diff --git a/poi/src/test/java/org/apache/poi/ss/util/TestWorkbookUtil.java 
b/poi/src/test/java/org/apache/poi/ss/util/TestWorkbookUtil.java
index 2fef666510..dbdee8ec8f 100644
--- a/poi/src/test/java/org/apache/poi/ss/util/TestWorkbookUtil.java
+++ b/poi/src/test/java/org/apache/poi/ss/util/TestWorkbookUtil.java
@@ -18,6 +18,7 @@
 package org.apache.poi.ss.util;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import org.junit.jupiter.api.Test;
 
@@ -87,4 +88,12 @@ final class TestWorkbookUtil {
         actual = WorkbookUtil.createSafeSheetName("sheet:a4");
         assertEquals("sheet a4", actual);
     }
+
+    @Test
+    void testValidateSheetNameRejectsControlCharacters() {
+        assertThrows(IllegalArgumentException.class,
+                () -> WorkbookUtil.validateSheetName("before\u0000after"));
+        assertThrows(IllegalArgumentException.class,
+                () -> WorkbookUtil.validateSheetName("before\u0003after"));
+    }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to