(polaris) branch main updated: Mark final fields as such (#159)

[snazy]

This is an automated email from the ASF dual-hosted git repository.

snazy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new 5e6a799  Mark final fields as such (#159)
5e6a799 is described below

commit 5e6a799acfa86f63a2495d2ac15fd08d993a5494
Author: Piotr Findeisen <piotr.findei...@gmail.com>
AuthorDate: Fri Aug 23 08:40:46 2024 +0200

    Mark final fields as such (#159)
    
    This also makes some LOGGER declarations static.
---
 .../io/polaris/service/PolarisApplicationIntegrationTest.java  |  2 +-
 .../service/catalog/PolarisRestCatalogIntegrationTest.java     |  2 +-
 .../service/catalog/PolarisRestCatalogViewIntegrationTest.java |  2 +-
 .../polaris/service/catalog/PolarisSparkIntegrationTest.java   |  2 +-
 .../src/test/java/io/polaris/service/task/TestSnapshot.java    | 10 +++++-----
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git 
a/polaris-service/src/test/java/io/polaris/service/PolarisApplicationIntegrationTest.java
 
b/polaris-service/src/test/java/io/polaris/service/PolarisApplicationIntegrationTest.java
index 1cd2edd..8799198 100644
--- 
a/polaris-service/src/test/java/io/polaris/service/PolarisApplicationIntegrationTest.java
+++ 
b/polaris-service/src/test/java/io/polaris/service/PolarisApplicationIntegrationTest.java
@@ -91,7 +91,7 @@ public class PolarisApplicationIntegrationTest {
       LoggerFactory.getLogger(PolarisApplicationIntegrationTest.class);
 
   public static final String PRINCIPAL_ROLE_NAME = "admin";
-  private static DropwizardAppExtension<PolarisApplicationConfig> EXT =
+  private static final DropwizardAppExtension<PolarisApplicationConfig> EXT =
       new DropwizardAppExtension<>(
           PolarisApplication.class,
           
ResourceHelpers.resourceFilePath("polaris-server-integrationtest.yml"),
diff --git 
a/polaris-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
 
b/polaris-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
index ac07812..710aaec 100644
--- 
a/polaris-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
+++ 
b/polaris-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
@@ -106,7 +106,7 @@ public class PolarisRestCatalogIntegrationTest extends 
CatalogTests<RESTCatalog>
   private static final String S3_BUCKET_BASE =
       Optional.ofNullable(System.getenv("INTEGRATION_TEST_S3_PATH"))
           .orElse("file:///tmp/buckets/my-bucket");
-  private static DropwizardAppExtension<PolarisApplicationConfig> EXT =
+  private static final DropwizardAppExtension<PolarisApplicationConfig> EXT =
       new DropwizardAppExtension<>(
           PolarisApplication.class,
           
ResourceHelpers.resourceFilePath("polaris-server-integrationtest.yml"),
diff --git 
a/polaris-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogViewIntegrationTest.java
 
b/polaris-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogViewIntegrationTest.java
index 1d7ebd8..2340718 100644
--- 
a/polaris-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogViewIntegrationTest.java
+++ 
b/polaris-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogViewIntegrationTest.java
@@ -76,7 +76,7 @@ public class PolarisRestCatalogViewIntegrationTest extends 
ViewCatalogTests<REST
   public static final String S3_BUCKET_BASE =
       Optional.ofNullable(System.getenv("INTEGRATION_TEST_S3_PATH"))
           .orElse("file:///tmp/buckets/my-bucket");
-  private static DropwizardAppExtension<PolarisApplicationConfig> EXT =
+  private static final DropwizardAppExtension<PolarisApplicationConfig> EXT =
       new DropwizardAppExtension<>(
           PolarisApplication.class,
           
ResourceHelpers.resourceFilePath("polaris-server-integrationtest.yml"),
diff --git 
a/polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java
 
b/polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java
index 7feec7d..d919a48 100644
--- 
a/polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java
+++ 
b/polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java
@@ -69,7 +69,7 @@ public class PolarisSparkIntegrationTest {
 
   public static final String CATALOG_NAME = "mycatalog";
   public static final String EXTERNAL_CATALOG_NAME = "external_catalog";
-  private static S3MockContainer s3Container =
+  private static final S3MockContainer s3Container =
       new 
S3MockContainer("3.9.1").withInitialBuckets("my-bucket,my-old-bucket");
   private static PolarisConnectionExtension.PolarisToken polarisToken;
   private static SparkSession spark;
diff --git 
a/polaris-service/src/test/java/io/polaris/service/task/TestSnapshot.java 
b/polaris-service/src/test/java/io/polaris/service/task/TestSnapshot.java
index 9ac7c1d..30734c6 100644
--- a/polaris-service/src/test/java/io/polaris/service/task/TestSnapshot.java
+++ b/polaris-service/src/test/java/io/polaris/service/task/TestSnapshot.java
@@ -31,11 +31,11 @@ import org.apache.iceberg.io.CloseableIterable;
 import org.apache.iceberg.io.FileIO;
 
 final class TestSnapshot implements Snapshot {
-  private long sequenceNumber;
-  private long snapshotId;
-  private long parentSnapshot;
-  private long timestampMillis;
-  private String manifestListLocation;
+  private final long sequenceNumber;
+  private final long snapshotId;
+  private final long parentSnapshot;
+  private final long timestampMillis;
+  private final String manifestListLocation;
 
   public TestSnapshot(
       long sequenceNumber,