RussellSpitzer commented on code in PR #193:
URL: https://github.com/apache/polaris/pull/193#discussion_r1730631709
##########
polaris-core/src/main/java/io/polaris/core/storage/PolarisStorageConfigurationInfo.java:
##########
@@ -171,11 +177,38 @@ public static Optional<PolarisStorageConfigurationInfo>
forEntityPath(
LOGGER.debug(
"Allowing unstructured table location for entity: {}",
entityPathReversed.get(0).getName());
- return configInfo;
+ return
userSpecifiedWriteLocations(entityPathReversed.get(0).getPropertiesAsMap())
Review Comment:
It looks like to avoid always doing a storage configuration override we are
using the Optional path below, It just feels like it may be simpler to just
always add Locs to the Config?
Or we could just do
if (userSpecifiedWriteLocations.notEmpty)
return Storage Override
else
configInfo
I'm not sure the functional style here makes it much more readable, One of
those things that I think would be much cleaner in Scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
