(polaris) branch main updated: Simplify Java streams usage (#200)

[russellspitzer]

This is an automated email from the ASF dual-hosted git repository.

russellspitzer pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new 821e332  Simplify Java streams usage (#200)
821e332 is described below

commit 821e3321a5783844bb04e0ba48d4f50ab318ba13
Author: Piotr Findeisen <piotr.findei...@gmail.com>
AuthorDate: Mon Aug 26 11:25:28 2024 +0200

    Simplify Java streams usage (#200)
---
 .../polaris/service/admin/PolarisServiceImplIntegrationTest.java  | 4 +++-
 .../apache/polaris/service/catalog/BasePolarisCatalogTest.java    | 8 +-------
 .../service/catalog/PolarisRestCatalogIntegrationTest.java        | 4 ++--
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git 
a/polaris-service/src/test/java/org/apache/polaris/service/admin/PolarisServiceImplIntegrationTest.java
 
b/polaris-service/src/test/java/org/apache/polaris/service/admin/PolarisServiceImplIntegrationTest.java
index 2b1bacb..22a4c42 100644
--- 
a/polaris-service/src/test/java/org/apache/polaris/service/admin/PolarisServiceImplIntegrationTest.java
+++ 
b/polaris-service/src/test/java/org/apache/polaris/service/admin/PolarisServiceImplIntegrationTest.java
@@ -107,7 +107,9 @@ public class PolarisServiceImplIntegrationTest {
   @AfterEach
   public void tearDown() {
     try (Response response = 
newRequest("http://localhost:%d/api/management/v1/catalogs";).get()) {
-      response.readEntity(Catalogs.class).getCatalogs().stream()
+      response
+          .readEntity(Catalogs.class)
+          .getCatalogs()
           .forEach(
               catalog ->
                   newRequest("http://localhost:%d/api/management/v1/catalogs/"; 
+ catalog.getName())
diff --git 
a/polaris-service/src/test/java/org/apache/polaris/service/catalog/BasePolarisCatalogTest.java
 
b/polaris-service/src/test/java/org/apache/polaris/service/catalog/BasePolarisCatalogTest.java
index 6a89f29..12caecb 100644
--- 
a/polaris-service/src/test/java/org/apache/polaris/service/catalog/BasePolarisCatalogTest.java
+++ 
b/polaris-service/src/test/java/org/apache/polaris/service/catalog/BasePolarisCatalogTest.java
@@ -34,7 +34,6 @@ import java.util.Map;
 import java.util.Set;
 import java.util.UUID;
 import java.util.function.Supplier;
-import java.util.stream.Collectors;
 import org.apache.commons.lang3.NotImplementedException;
 import org.apache.iceberg.BaseTable;
 import org.apache.iceberg.CatalogProperties;
@@ -1143,12 +1142,7 @@ public class BasePolarisCatalogTest extends 
CatalogTests<BasePolarisCatalog> {
   private void createNonExistingNamespaces(Namespace namespace) {
     // Pre-create namespaces if they don't exist
     for (int i = 1; i <= namespace.length(); i++) {
-      Namespace nsLevel =
-          Namespace.of(
-              Arrays.stream(namespace.levels())
-                  .limit(i)
-                  .collect(Collectors.toList())
-                  .toArray(String[]::new));
+      Namespace nsLevel = Namespace.of(Arrays.copyOf(namespace.levels(), i));
       if (!catalog.namespaceExists(nsLevel)) {
         catalog.createNamespace(nsLevel);
       }
diff --git 
a/polaris-service/src/test/java/org/apache/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
 
b/polaris-service/src/test/java/org/apache/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
index 0f2a8ac..784f8d8 100644
--- 
a/polaris-service/src/test/java/org/apache/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
+++ 
b/polaris-service/src/test/java/org/apache/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
@@ -480,7 +480,7 @@ public class PolarisRestCatalogIntegrationTest extends 
CatalogTests<RESTCatalog>
             tableGrant2,
             viewGrant1,
             viewGrant2);
-    role1Grants.stream().forEach(grant -> addGrant("catalogrole1", grant));
+    role1Grants.forEach(grant -> addGrant("catalogrole1", grant));
     List<GrantResource> role2Grants =
         List.of(
             catalogGrant1,
@@ -491,7 +491,7 @@ public class PolarisRestCatalogIntegrationTest extends 
CatalogTests<RESTCatalog>
             tableGrant3,
             viewGrant1,
             viewGrant3);
-    role2Grants.stream().forEach(grant -> addGrant("catalogrole2", grant));
+    role2Grants.forEach(grant -> addGrant("catalogrole2", grant));
 
     // List grants for catalogrole1
     try (Response response =