eric-maynard commented on code in PR #195: URL: https://github.com/apache/polaris/pull/195#discussion_r1731542406
########## docs/configuring-polaris-for-production.md: ########## @@ -55,6 +55,13 @@ Be sure to secure your metastore backend since it will be storing credentials an To use [EclipseLink](https://eclipse.dev/eclipselink/) for metastore management, specify the configuration `metaStoreManager.conf-file` to point to an [EclipseLink `persistence.xml` file](https://eclipse.dev/eclipselink/documentation/2.5/solutions/testingjpa002.htm). This file, local to the Polaris service, will contain information on what database to use for metastore management and how to connect to it. +> [!IMPORTANT] +> To use [EclipseLink](https://eclipse.dev/eclipselink), you need to ensure that you have done two things: Review Comment: EclipseLink is already linked above, so let's not link it here. ########## docs/configuring-polaris-for-production.md: ########## @@ -55,6 +55,13 @@ Be sure to secure your metastore backend since it will be storing credentials an To use [EclipseLink](https://eclipse.dev/eclipselink/) for metastore management, specify the configuration `metaStoreManager.conf-file` to point to an [EclipseLink `persistence.xml` file](https://eclipse.dev/eclipselink/documentation/2.5/solutions/testingjpa002.htm). This file, local to the Polaris service, will contain information on what database to use for metastore management and how to connect to it. +> [!IMPORTANT] +> To use [EclipseLink](https://eclipse.dev/eclipselink), you need to ensure that you have done two things: +> 1. Build the jar for the EclipseLink extension Review Comment: style: To match the tense of the above line, this should be `Built` not `Build` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
