eric-maynard commented on code in PR #165:
URL: https://github.com/apache/polaris/pull/165#discussion_r1734993543
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfigurationStore.java:
##########
@@ -68,6 +69,8 @@ public interface PolarisConfigurationStore {
if (config.defaultValue instanceof Boolean) {
return config.cast(Boolean.valueOf(String.valueOf(value)));
+ } else if (config.defaultValue instanceof List<?>) {
+ return config.cast(List.copyOf((List<?>) value));
Review Comment:
Agreed, this is quite ugly to have in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
