adutra commented on code in PR #282:
URL: https://github.com/apache/polaris/pull/282#discussion_r1759364019
##########
polaris-core/src/test/java/org/apache/polaris/service/storage/aws/AwsCredentialsStorageIntegrationTest.java:
##########
@@ -94,26 +88,11 @@ public void testGetSubscopedCreds() {
.containsEntry(PolarisCredentialProperty.AWS_SECRET_KEY, "secretKey");
}
- @ParameterizedTest
- @ValueSource(strings = {AWS_PARTITION, "aws-cn", "aws-us-gov"})
Review Comment:
You are right that I need to override `validate()` in
`StorageConfigurationOverride` – the current code looks really fishy as it
mixes validation on the override instance vs on the delegate instance.
But unfortunately the problem with ARN domains cannot be solved like this:
the `validateArn()` method belongs to the AWS subtype and the subtype is being
constructed directly in the test, with the forbidden domains. I will find
something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
