eric-maynard commented on code in PR #282:
URL: https://github.com/apache/polaris/pull/282#discussion_r1763830479
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/FileStorageConfigurationInfo.java:
##########
@@ -18,30 +18,47 @@
*/
package org.apache.polaris.core.storage;
-import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import com.fasterxml.jackson.databind.annotation.JsonSerialize;
import java.util.List;
-import org.jetbrains.annotations.NotNull;
+import org.apache.polaris.immutables.PolarisImmutable;
+import org.immutables.value.Value;
/**
* Support for file:// URLs in storage configuration. This is pretty-much only
used for testing.
* Supports URLs that start with file:// or /, but also supports wildcard (*)
to support certain
* test cases.
*/
-public class FileStorageConfigurationInfo extends
PolarisStorageConfigurationInfo {
+@PolarisImmutable
+@JsonSerialize(as = ImmutableFileStorageConfigurationInfo.class)
+@JsonDeserialize(as = ImmutableFileStorageConfigurationInfo.class)
Review Comment:
Do we actually _need_ to add this to classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
