MonkeyCanCode commented on code in PR #227:
URL: https://github.com/apache/polaris/pull/227#discussion_r1769334267
##########
run.sh:
##########
@@ -21,20 +21,51 @@
# Runs Polaris as a mini-deployment locally. Creates two pods that bind
themselves to port 8181.
-CURRENT_DIR=$(pwd)
+# Initialize variables
+ECLIPSELINK="false" # Default value
-# deploy the registry
+# Function to display usage information
+usage() {
+ echo "Usage: $0 [-e true|false] [-h]"
+ echo " -e Set the ECLIPSELINK flag (default: false)"
+ echo " -h Display this help message"
+ exit 1
+}
Review Comment:
actually lets have it in a diff PR. The current Dockerfile doesn't support
eclipseLinkDeps flag. I will add this in and update the doc for both optional
options. What do u think?
@flyrain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
