This is an automated email from the ASF dual-hosted git repository.
jbonofre pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new 92ae7236c Add a note about nit/minor comments (#1280)
92ae7236c is described below
commit 92ae7236c107388c31b98c78ee9b869d2f6b1c33
Author: JB Onofré <[email protected]>
AuthorDate: Mon Mar 31 20:39:46 2025 +0200
Add a note about nit/minor comments (#1280)
---
CONTRIBUTING.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 6e616e552..d01dca6d2 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -104,6 +104,6 @@ The Apache Polaris build currently requires Java 21 or
later. There are a few to
The discussion on the dev mailing list should happen before having a
"ready-for-review" Pull Request.
* `git log` can help you find the original/relevant authors of the code you
are modifying. If you need, feel free to tag the author in your Pull Request
comment if you need assistance or review.
* Do not re-create a pull-request for the same change. Use one Pull Request
related to the same change(s). The purpose here is to keep the history and all
comments in the Pull Request.
-* Consider open questions and concerns in all comments of your Pull Request,
provide replies and resolve addressed comments, if those don't serve reference
purposes.
+* Consider open questions and concerns in all comments of your Pull Request,
provide replies and resolve addressed comments, if those don't serve reference
purposes. If a comment doesn't contain `nit`, `minor`, or `not a blocker`
mention, please provide feedback to the comment before merging.
* Give time for review. For instance two working days is a good base to get
first reviews and comments.
* If you have the feeling that the discussions in a Pull Request are not going
to a consensus, feel free to bring the discussion on the dev mailing list.
