(polaris) branch main updated: Remove CallContext.getAuthenticatedPrincipal() (#1400)

[adutra]

This is an automated email from the ASF dual-hosted git repository.

adutra pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new ca99c53b9 Remove CallContext.getAuthenticatedPrincipal() (#1400)
ca99c53b9 is described below

commit ca99c53b9c5be9022b3f4960b0d998a0cc9a4b84
Author: Alexandre Dutra <adu...@users.noreply.github.com>
AuthorDate: Fri Apr 18 22:17:30 2025 +0200

    Remove CallContext.getAuthenticatedPrincipal() (#1400)
---
 .../main/java/org/apache/polaris/core/context/CallContext.java   | 9 ---------
 .../apache/polaris/service/auth/BasePolarisAuthenticator.java    | 2 --
 2 files changed, 11 deletions(-)

diff --git 
a/polaris-core/src/main/java/org/apache/polaris/core/context/CallContext.java 
b/polaris-core/src/main/java/org/apache/polaris/core/context/CallContext.java
index 71c457720..6cd56bc30 100644
--- 
a/polaris-core/src/main/java/org/apache/polaris/core/context/CallContext.java
+++ 
b/polaris-core/src/main/java/org/apache/polaris/core/context/CallContext.java
@@ -26,7 +26,6 @@ import java.util.stream.Collectors;
 import org.apache.iceberg.io.CloseableGroup;
 import org.apache.polaris.core.PolarisCallContext;
 import org.apache.polaris.core.PolarisDiagnostics;
-import org.apache.polaris.core.auth.AuthenticatedPolarisPrincipal;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -45,9 +44,6 @@ public interface CallContext extends AutoCloseable {
   // created, scoped to the current call context.
   String REQUEST_PATH_CATALOG_INSTANCE_KEY = "REQUEST_PATH_CATALOG_INSTANCE";
 
-  // Authenticator filters should populate this field alongside resolving a 
SecurityContext.
-  // Value type: AuthenticatedPolarisPrincipal
-  String AUTHENTICATED_PRINCIPAL = "AUTHENTICATED_PRINCIPAL";
   String CLOSEABLES = "closeables";
 
   static CallContext setCurrentContext(CallContext context) {
@@ -63,11 +59,6 @@ public interface CallContext extends AutoCloseable {
     return CURRENT_CONTEXT.get().getPolarisCallContext().getDiagServices();
   }
 
-  static AuthenticatedPolarisPrincipal getAuthenticatedPrincipal() {
-    return (AuthenticatedPolarisPrincipal)
-        
CallContext.getCurrentContext().contextVariables().get(CallContext.AUTHENTICATED_PRINCIPAL);
-  }
-
   static void unsetCurrentContext() {
     CURRENT_CONTEXT.remove();
   }
diff --git 
a/service/common/src/main/java/org/apache/polaris/service/auth/BasePolarisAuthenticator.java
 
b/service/common/src/main/java/org/apache/polaris/service/auth/BasePolarisAuthenticator.java
index 5c284a934..ad2f9da4c 100644
--- 
a/service/common/src/main/java/org/apache/polaris/service/auth/BasePolarisAuthenticator.java
+++ 
b/service/common/src/main/java/org/apache/polaris/service/auth/BasePolarisAuthenticator.java
@@ -111,8 +111,6 @@ public abstract class BasePolarisAuthenticator
 
     AuthenticatedPolarisPrincipal authenticatedPrincipal =
         new AuthenticatedPolarisPrincipal(new PrincipalEntity(principal), 
activatedPrincipalRoles);
-    LOGGER.debug("Populating authenticatedPrincipal into CallContext: {}", 
authenticatedPrincipal);
-    callContext.contextVariables().put(CallContext.AUTHENTICATED_PRINCIPAL, 
authenticatedPrincipal);
     return Optional.of(authenticatedPrincipal);
   }
 }