This is an automated email from the ASF dual-hosted git repository.

snazy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new f3d53f02a CI: Fix Gradle cache usages (#2593)
f3d53f02a is described below

commit f3d53f02a9e9e367a323e6501a2d232071246106
Author: Robert Stupp <[email protected]>
AuthorDate: Wed Sep 17 18:51:20 2025 +0200

    CI: Fix Gradle cache usages (#2593)
    
    The GH action `ci-incr-build-cache-prepare` calls the `setup-gradle` action 
with the "right" parameters, so the call of `setup-gradle` in jobs that use 
`ci-incr-build-cache-prepare` is superfluous. But this also renders the caching 
ineffective as `setup-gradle` is called w/o `cache-read-only: true` in "child 
jobs", which then attempt to store their Gradle cache contents. This leads to 
attempty storing the Gradle cache in `Post Setup Gradle` steps of the "child" 
jobs, conflicting with  [...]
    
    "Which cache" is then restored, is rather non-deterministic, but almost 
always at least "partial" leading to unnecessary (re)builds.
---
 .github/workflows/gradle.yml                | 16 ----------------
 .github/workflows/nightly.yml               |  7 +++----
 .github/workflows/regtest.yml               |  5 -----
 .github/workflows/spark_client_regtests.yml |  5 -----
 4 files changed, 3 insertions(+), 30 deletions(-)

diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
index 282cc46ab..ddd44140a 100644
--- a/.github/workflows/gradle.yml
+++ b/.github/workflows/gradle.yml
@@ -46,10 +46,6 @@ jobs:
         with:
           java-version: '21'
           distribution: 'temurin'
-      - name: Setup Gradle
-        uses: 
gradle/actions/setup-gradle@ed408507eac070d1f99cc633dbcf757c94c7933a # v4
-        with:
-          validate-wrappers: false
       - name: Prepare Gradle build cache
         uses: ./.github/actions/ci-incr-build-cache-prepare
       - name: Run unit tests
@@ -88,10 +84,6 @@ jobs:
         with:
           java-version: '21'
           distribution: 'temurin'
-      - name: Setup Gradle
-        uses: 
gradle/actions/setup-gradle@ed408507eac070d1f99cc633dbcf757c94c7933a # v4
-        with:
-          validate-wrappers: false
       - name: Prepare Gradle build cache
         uses: ./.github/actions/ci-incr-build-cache-prepare
       - name: Run Quarkus tests
@@ -128,10 +120,6 @@ jobs:
         with:
           java-version: '21'
           distribution: 'temurin'
-      - name: Setup Gradle
-        uses: 
gradle/actions/setup-gradle@ed408507eac070d1f99cc633dbcf757c94c7933a # v4
-        with:
-          validate-wrappers: false
       - name: Prepare Gradle build cache
         uses: ./.github/actions/ci-incr-build-cache-prepare
       - name: Run integration tests
@@ -168,10 +156,6 @@ jobs:
         with:
           java-version: '21'
           distribution: 'temurin'
-      - name: Setup Gradle
-        uses: 
gradle/actions/setup-gradle@ed408507eac070d1f99cc633dbcf757c94c7933a # v4
-        with:
-          validate-wrappers: false
       - name: Collect partial Gradle build caches
         uses: ./.github/actions/ci-incr-build-cache-prepare
         with:
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index 3463a39dd..931fa79b4 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -52,10 +52,9 @@ jobs:
         with:
           java-version: '21'
           distribution: 'temurin'
-      - name: Setup Gradle
-        uses: 
gradle/actions/setup-gradle@ed408507eac070d1f99cc633dbcf757c94c7933a # v4
-        with:
-          validate-wrappers: false
+
+      - name: Prepare Gradle build cache
+        uses: ./.github/actions/ci-incr-build-cache-prepare
       - name: Publish SNAPSHOTs to Apache Nexus Repository
         run: ./gradlew publishToApache
         env:
diff --git a/.github/workflows/regtest.yml b/.github/workflows/regtest.yml
index e0ea027d2..f4a8a4c7a 100644
--- a/.github/workflows/regtest.yml
+++ b/.github/workflows/regtest.yml
@@ -40,11 +40,6 @@ jobs:
           java-version: '21'
           distribution: 'temurin'
 
-      - name: Setup Gradle
-        uses: 
gradle/actions/setup-gradle@ed408507eac070d1f99cc633dbcf757c94c7933a # v4
-        with:
-          validate-wrappers: false
-
       - name: Prepare Gradle build cache
         uses: ./.github/actions/ci-incr-build-cache-prepare
 
diff --git a/.github/workflows/spark_client_regtests.yml 
b/.github/workflows/spark_client_regtests.yml
index ec24f17da..4381a2702 100644
--- a/.github/workflows/spark_client_regtests.yml
+++ b/.github/workflows/spark_client_regtests.yml
@@ -40,11 +40,6 @@ jobs:
           java-version: '21'
           distribution: 'temurin'
 
-      - name: Setup Gradle
-        uses: 
gradle/actions/setup-gradle@ed408507eac070d1f99cc633dbcf757c94c7933a # v4
-        with:
-          validate-wrappers: false
-
       - name: Prepare Gradle build cache
         uses: ./.github/actions/ci-incr-build-cache-prepare
 

Reply via email to