espy commented on PR #9207:
URL: https://github.com/apache/pouchdb/pull/9207#issuecomment-4142564544

   All green āœ…
   
   Turns out this PR only affects 4 tests, the combination of which seem a bit 
odd (see end of comment):
   ```
   couchdb-browser (2.3, firefox, TYPE=find PLUGINS=pouchdb-find ADAPTERS=http 
npm test)
   couchdb-browser (2.3, firefox, TYPE=mapreduce ADAPTERS=http npm test)
   couchdb-browser (3.1, chromium, TYPE=mapreduce ADAPTERS=http npm test)
   browser-adapter (chromium, indexeddb, TYPE=mapreduce npm test)
   ```
   
   BUT! These go from ~8:30 to ~1:30 _each_ compared to the [baseline 
run](https://github.com/apache/pouchdb/actions/runs/23362717092/job/67969775567).
   
   **First test run:** 
   
   Cumulative test runtime is decreased from to `3h 17m 52s` to `2h 53m 50s`.
   Total runtime is down from 9m 30s to 7m
   
   **Second test run:**
   
   Cumulative test runtime is decreased from to `3h 17m 52s` to `2h 54m 50s`.
   Total runtime is down from 9m 30s to 6m 30s
   
   This seems like a nice win.
   
   **Why does the combination seem odd?**
   
   I’d have expected similar tests to behave similarly, e.g. all playwright 
Chromium runs go through the same installation step, why are some consistently 
slower when the slow step happens in all of them? šŸ¤”
   
   ```
   browser-adapter (chromium, indexeddb, npm test)                              
           4m 0s        
   browser-adapter (chromium, indexeddb, TYPE=find PLUGINS=pouchdb-find npm 
test)          1m 12s       
   browser-adapter (chromium, indexeddb, TYPE=mapreduce npm test)               
           8m 53s
        
   couchdb-browser (2.3, firefox, npm test)                                     
           5m 26s       
   couchdb-browser (2.3, firefox, TYPE=find PLUGINS=pouchdb-find ADAPTERS=http 
npm test)   8m 58s       
   couchdb-browser (2.3, firefox, TYPE=mapreduce ADAPTERS=http npm test)        
           8m 55s
   
   couchdb-browser (3.1, chromium, npm test)                                    
           3m 55s       
   couchdb-browser (3.1, chromium, TYPE=find PLUGINS=pouchdb-find ADAPTERS=http 
npm test)  1m 15s       
   couchdb-browser (3.1, chromium, TYPE=mapreduce ADAPTERS=http npm test)       
           8m 28s
   ```  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to