AlbaHerrerias opened a new pull request, #9223:
URL: https://github.com/apache/pouchdb/pull/9223
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that PouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from
committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
PouchDB committer.
Artificial Intelligence and Large Language Models Contributions Policy
It is expressly forbidden to contribute material generated by
AI, LLMs, and similar technologies, to the PouchDB project.
This includes, but is not limited to, source code, documentation,
commit messages, or any other areas of the project.
-->
## Overview
Hello! đź‘‹
We are from the [Neighbourhoodie Software](https://neighbourhood.ie/), the
implementation partner of the [STA Bug Resilience
Program](https://www.sovereign.tech/programs/bug-resilience). This work is part
of our agreed 'Milestone 1. Deprecate and Remove LevelDB Subsystem'.
This PR introduces `pouchdb-adapter-nodesqlite`, that internally uses
[Node.js's native SQLite module](https://nodejs.org/api/sqlite.html) as its
persistence layer. The adapter is based on the original
`pouchdb-adapter-websql-core`, which is compatible with SQLite, and used to be
part of PouchDB and is still part of the repository history. Re-incorporating
it should be fine and covered by Dale’s and Nolan’s respective grants to the
ASF.
The adapter depends on `node-websql`, which has been [forked and
adapted](https://github.com/neighbourhoodie/node-websql) from its
[original](https://github.com/nolanlawson/node-websql). `node-websql` is all
Nolan’s work and we will have to obtain a new grant if we wanted to integrate
it into the Apache PouchDB's source code, so for now we have made it a forked
dependency.
This represents the first step on deprecating and removing the LevelDB
Subsystem that PouchDB depends on and wants to move away from.
Thank you
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provide any behaviour that the end users
could notice? -->
As usual. A new job has been introduced to test this adapter in GitHub
Actions, as Node.js's SQLite module was introduced in version 22.5.0 and the
other jobs are being tested in 20 as well.
## Related Issues or Pull Requests
<!-- If your changes affect multiple components in different
repositories please put links to those issues or pull requests here.
-->
Related https://github.com/apache/pouchdb/issues/9163
## Checklist
- [x] I am not a bot
- [x] This is my own work, I did not use AI, LLM's or similar technology for
code or docs generation
- [x] Code is written and works correctly
- [x] Changes are covered by tests
- [ ] Documentation changes were made in the `docs` folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
