merlimat opened a new pull request #2671: Simplify ServiceUrlProvider related APIs URL: https://github.com/apache/pulsar/pull/2671 ### Motivation I have seen few issues with ee5afa5007e260891140956d244a865d73368321: 1. There are 3 new methods in the `PulsarClient` interface which are meant to be used together. We should reduce the public API to the minimum possible. So I propose to just have a `Pulsar.updateServiceUrl()` which internally will perform all the needed operations in order to reconnect the client to new endpoint. 2. We shouldn't be exposing `ClientConfigurationData` in the API since it belongs to `impl` package 3. There is a leak of resources when the `LookupService` gets replaced with the new one since the existing is not closed. ### Modifications Refactored to simplify API for adding `ServiceUrlProvider` cc/ @codelipenghui It would be good to get this into 2.2 since it's changing the API for this new feature.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
