[GitHub] srkukarni commented on a change in pull request #2728: [function][runtime] NPE at RuntimeSpawner

[GitBox]

srkukarni commented on a change in pull request #2728: [function][runtime] NPE 
at RuntimeSpawner
URL: https://github.com/apache/pulsar/pull/2728#discussion_r222866647
 
 

 ##########
 File path: 
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
 ##########
 @@ -82,7 +83,8 @@ public void start() throws Exception {
             processLivenessCheckTimer.scheduleAtFixedRate(new TimerTask() {
                 @Override
                 public void run() {
-                    if (!runtime.isAlive()) {
+                    Runtime runtime = RuntimeSpawner.this.runtime;
 
 Review comment:
   When does runtime become null?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services