rdhabalia commented on a change in pull request #2730: [schema] provide a flag to disable/enable schema validation on broker and change default bytes producer to use `AUTO_PRODUCE_BYTES` URL: https://github.com/apache/pulsar/pull/2730#discussion_r222907660
########## File path: conf/broker.conf ########## @@ -517,6 +517,13 @@ exposePublisherStats=true # The schema storage implementation used by this broker schemaRegistryStorageClassName=org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory +# Enforce schema validation on following cases: +# +# - if a producer without a schema attempts to produce to a topic with schema, the producer will be +# failed to connect. PLEASE be carefully on using this, since non-java clients don't support schema. +# if you enable this setting, it will cause non-java clients failed to produce. +isSchemaValidationEnforced=false Review comment: but with this option, isn't a chance that producer without schema can inject incompatible data. So, it's better to reject the request without schema, if schema is enabled for that topic.? however, we can always remove this flag in future if we don't see any meaning. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
