ivankelly commented on a change in pull request #2730: [schema] provide a flag 
to disable/enable schema validation on broker and change default bytes producer 
to use `AUTO_PRODUCE_BYTES`
URL: https://github.com/apache/pulsar/pull/2730#discussion_r223007365
 
 

 ##########
 File path: 
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleSchemaTest.java
 ##########
 @@ -131,9 +132,7 @@ public void newProducerWithoutSchemaOnTopicWithSchema() 
throws Exception {
         }
 
         try (Producer<byte[]> p = 
pulsarClient.newProducer().topic(topic).create()) {
-            Assert.fail("Shouldn't be able to connect to a schema'd topic with 
no schema");
-        } catch (PulsarClientException e) {
-            
Assert.assertTrue(e.getMessage().contains("IncompatibleSchemaException"));
+            p.send("junkdata".getBytes(UTF_8));
 
 Review comment:
   We also need the complimentary test, where schema _is_ being enforced (i.e. 
the original test).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to