david-streamlio commented on issue #2615: Azure offloader URL: https://github.com/apache/pulsar/pull/2615#issuecomment-427405837 I am open to suggestions on how to split these up, but these changes are tightly coupled. I could remove the Glacier offloader, but that would be just one class. The refactor moved all of the logic for getting the credentials out of a single class with multiple if/the/else if/else if constructs and into a factory. Then I refactored the S3, and GCS to use the new factory methods, and added Azure.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
