jerrypeng commented on a change in pull request #2756: Do not create any
producer if the output type of a function is void
URL: https://github.com/apache/pulsar/pull/2756#discussion_r223909979
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java
##########
@@ -235,6 +239,7 @@ public void open(Map<String, Object> config, SinkContext
sinkContext) throws Exc
@Override
public void write(Record<T> record) throws Exception {
+ if (record == null) return;
Review comment:
Actually I don't think this is needed:
https://github.com/apache/pulsar/blob/master/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java#L318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
