jerrypeng commented on a change in pull request #2813: Removed Validation
Annotations and do manual Validation
URL: https://github.com/apache/pulsar/pull/2813#discussion_r227067103
##########
File path:
pulsar-functions/instance/src/test/java/org/apache/pulsar/functions/windowing/WindowFunctionExecutorTest.java
##########
@@ -218,24 +218,14 @@ public void testExecuteWithLateTupleStream() throws
Exception {
@Test
public void testSettingSlidingCountWindow() throws Exception {
final Object[][] args = new Object[][]{
- {-1, 10},
Review comment:
We have to separate them? We have positive test cases in one class and
negative test cases in another. That is really confusing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
