srkukarni commented on a change in pull request #2817: Logs should be output to
stdout when running functions in Kubernetes
URL: https://github.com/apache/pulsar/pull/2817#discussion_r227106898
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
##########
@@ -129,7 +129,7 @@
this.originalCodeFileName = pulsarRootDir + "/" + originalCodeFileName;
this.pulsarAdminUrl = pulsarAdminUrl;
this.processArgs = RuntimeUtils.composeArgs(instanceConfig,
instanceFile, logDirectory, this.originalCodeFileName, pulsarServiceUrl,
stateStorageServiceUrl,
- authConfig, "$" + ENV_SHARD_ID, GRPC_PORT, -1l, pulsarRootDir
+ "/conf/log4j2.yaml", installUserCodeDependencies);
+ authConfig, "$" + ENV_SHARD_ID, GRPC_PORT, -1l,
"kubernetes_instance_log4j2.yml", installUserCodeDependencies);
Review comment:
Shouldn't this be prefixed with pulsarRootDir?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
