merlimat commented on a change in pull request #2826: Secrets Interface
URL: https://github.com/apache/pulsar/pull/2826#discussion_r227598833
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/io/SinkConfig.java
##########
@@ -55,6 +55,7 @@
private Map<String, ConsumerConfig> inputSpecs = new TreeMap<>();
private Map<String, Object> configs;
+ private Map<String, String> secrets;
Review comment:
This might need to be a bit more complex with 2 levels.
Secrets providers typically have notion of multiple "keys" within a single
secret
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
