cckellogg commented on a change in pull request #2826: Secrets Interface
URL: https://github.com/apache/pulsar/pull/2826#discussion_r227602068
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
##########
@@ -519,12 +535,27 @@ private V1Container getFunctionContainer(List<String>
instanceCommand, Function.
container.setCommand(instanceCommand);
// setup the environment variables for the container
+ List<V1EnvVar> envVars = new LinkedList<>();
final V1EnvVar envVarPodName = new V1EnvVar();
envVarPodName.name("POD_NAME")
.valueFrom(new V1EnvVarSource()
.fieldRef(new V1ObjectFieldSelector()
.fieldPath("metadata.name")));
- container.setEnv(Arrays.asList(envVarPodName));
+ envVars.add(envVarPodName);
+ if
(!StringUtils.isEmpty(instanceConfig.getFunctionDetails().getSecretsMap())) {
Review comment:
can this abstracted and delegated to a secrets backend provider
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
