cckellogg commented on a change in pull request #2875: Hooked up secrets
function api with secret function implementations
URL: https://github.com/apache/pulsar/pull/2875#discussion_r228764406
##########
File path:
pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/SchedulerManagerTest.java
##########
@@ -783,7 +784,7 @@ public void testAssignmentWorkerDoesNotExist() throws
InterruptedException, NoSu
functionMetaDataList.add(function2);
doReturn(functionMetaDataList).when(functionMetaDataManager).getAllFunctionMetaData();
- ThreadRuntimeFactory factory = new ThreadRuntimeFactory("dummy", null,
"dummy");
+ ThreadRuntimeFactory factory = new ThreadRuntimeFactory("dummy", null,
"dummy", ClearTextSecretsProvider.class.getName(), null);
Review comment:
can we have some of these test pass something other than null for the config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
