sijie commented on a change in pull request #2923: Allow configuring extra
dependencies directory for functions
URL: https://github.com/apache/pulsar/pull/2923#discussion_r230572093
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -123,6 +122,8 @@
private String javaInstanceJarLocation;
private String pythonInstanceLocation;
private String logDirectory;
+ // the directory for dropping extra function dependencies
+ private String extraFunctionDependenciesLocation;
Review comment:
I make them different, because the behavior in process mode and k8s is
different. Because k8s has a pulsarRootDir, but process mode doesn’t. If we use
the same name, it will become confused.
However I am open to any change, if you think we should use same variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
