jerrypeng commented on a change in pull request #2930: Expose metrics via http
port in function instance
URL: https://github.com/apache/pulsar/pull/2930#discussion_r230922997
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java
##########
@@ -195,12 +213,13 @@ public void run() {
}
});
- // registering jvm metrics to prometheus
- DefaultExports.initialize();
-
log.info("Starting runtimeSpawner");
runtimeSpawner.start();
+ // starting metrics server
+ log.info("Starting metrics server on port {}", metrics_port);
Review comment:
are we exposing that config to the user somehow? Because currently its
always going to be set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
