srkukarni commented on a change in pull request #2930: Expose metrics via http
port in function instance
URL: https://github.com/apache/pulsar/pull/2930#discussion_r230974775
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
##########
@@ -130,7 +131,8 @@ public FunctionRuntimeManager(WorkerConfig workerConfig,
WorkerService workerSer
workerConfig.getPulsarServiceUrl(),
workerConfig.getStateStorageServiceUrl(),
authConfig,
- new ClearTextSecretsProvider());
+ new ClearTextSecretsProvider(),
+ null);
Review comment:
why null? Can't we create a Registry and pass it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
