sijie commented on a change in pull request #3021: adding windowed metrics for functions URL: https://github.com/apache/pulsar/pull/3021#discussion_r235091471
########## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/InstanceCache.java ########## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.functions.instance; + +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; + +public class InstanceCache { Review comment: what is the consideration behind this `InstanceCache` class? because it seems to be only used in JavaInstanceRunnable. Then why not just run it as part of JavaInstanceRunnable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
