jerrypeng commented on a change in pull request #3179: [Pulsar-IO] Add Netty Tcp Source Support URL: https://github.com/apache/pulsar/pull/3179#discussion_r241214656
########## File path: pulsar-io/netty/src/main/resources/META-INF/services/pulsar-io.yaml ########## @@ -0,0 +1,22 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: netty Review comment: I think we should call the connector tcp. It will be clearer to the user what this connector does. At the end of the day the user will submit a command as such: ./bin/pulsar-admin source create --name test --destinationTopicName test --source-type tcp is clearer than: ./bin/pulsar-admin source create --name test --destinationTopicName test --source-type netty ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
