lovelle edited a comment on issue #3155: Deferred messages for consumers
URL: https://github.com/apache/pulsar/pull/3155#issuecomment-446819094
 
 
   @codelipenghui 
   
   > If can't depends on client clock, i think publish time now be 
client-generated
   
   Yes, as far as I understand publish time is set 
[here](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L348)
 this should be set by broker instead of client, do you see any problem in 
doing so?
   
   Just to clarify this one step further, I can see two main features with the 
`delayed message` topic.
   
   1. Consumer dependent delay (this pr) would be used just to having some 
delay on _every_ message of the consumer, maybe for short period of times, in 
the range or less than minutes. And the obvious advantage is that the producer 
does not need to be aware of such delay.
   
   2. Publisher dependent delay (#2375 and 
[here](https://github.com/apache/pulsar/wiki/PIP-26%3A-Delayed-Message-Delivery))
 I think this feature is more advance and complex and the proposed way is a 
really good path, since the time of delay for deliver such messages could be 
far in time and totally different from each other, therefore, messages need to 
be structured in consideration with this factor.
   
   I think both approaches would be great to have on pulsar since they are used 
for different purposes.
   
   So, on 2nd approach we could do what you propose if I'm not wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to