jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364610
########## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ########## @@ -884,12 +869,10 @@ public void testUpdateSourceFailure() throws Exception { CompletableFuture<RequestResult> requestResult = CompletableFuture.completedFuture(rr); when(mockedManager.updateFunction(any(FunctionMetaData.class))).thenReturn(requestResult); - Response response = updateDefaultSource(); - assertEquals(Status.BAD_REQUEST.getStatusCode(), response.getStatus()); Review comment: we should still check status code ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services